Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector Tiles: add a more generic way of building meta layer #71804

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Vector Tiles: add a more generic way of building meta layer #71804

merged 1 commit into from
Apr 19, 2021

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Apr 19, 2021

Replaces a manual way of building the meta layer with a more generic way
of collecting unprocessed elements of the search response. That should get
us started. I will add a dedicated test for Maps.flatten method and support
for arrays in the next PR.

@imotov
Vector Tiles: add a more generic way of building meta layer
12817ed 
Replaces a manual way of building the meta layer with a more generic way
of collecting unprocessed elements of the search response
@imotov imotov added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Apr 19, 2021
@imotov imotov requested a review from iverase April 19, 2021 02:37
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

iverase
iverase approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I didn't know about SearchResponseSections, and basically we are building a new response with all the bits that might get serialise in meta.

@imotov imotov merged commit 7b6f3da into elastic:feature/vector-tiles Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iverase iverase iverase approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imotov @elasticmachine @iverase